Skip to content

extra::getopts::opt_val is private, but rustpkg managed to use it due to privacy bugs. #9311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kimundi opened this issue Sep 19, 2013 · 3 comments · Fixed by #10372
Closed

extra::getopts::opt_val is private, but rustpkg managed to use it due to privacy bugs. #9311

Kimundi opened this issue Sep 19, 2013 · 3 comments · Fixed by #10372

Comments

@Kimundi
Copy link
Member

Kimundi commented Sep 19, 2013

@catamorphism you're the one who handles rustpkg, right? Can you take a look on whether those two getopts methods are necessary there? Alternatively, document what they actually do and make them officially public. I still have no idea what half the things in getopts actually do.
@huonw
Copy link
Member

huonw commented Sep 19, 2013

Couldn't the function be made public?

@Kimundi
Copy link
Member Author

Kimundi commented Sep 19, 2013

@huonw I have some aversion against making two undocumented functions public that I do not understand, despite both being only like 5 lines of code.

@ghost ghost assigned catamorphism Sep 20, 2013
@catamorphism
Copy link
Contributor

They should be public. I'll fix this.

@catamorphism catamorphism mentioned this issue Nov 9, 2013
Merged
bors added a commit that referenced this issue Nov 9, 2013
@bors
auto merge of #10372 : catamorphism/rust/rustpkg-issue-9311, r=catamo…
dc5d9b9 
…rphism

and use opt_str instead of opt_val in rustpkg

Closes #9311
flip1995 pushed a commit to flip1995/rust that referenced this issue Jun 30, 2023
@bors
Auto merge of rust-lang#10907 - Alexendoo:dev-new-lint-late-passes, r…
ff3b49c 
…=Jarcho

Direct towards late passes in `cargo dev new_lint`

changelog: none

This would be the tooling part of rust-lang#9311

- `--pass late` is now the default
- It prints a message recommending the use of a late pass if you choose `--pass early`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

extra / rustpkg: Make getopts::opt_val private again catamorphism/rust
3 participants
@catamorphism @huonw @Kimundi