Skip to content

investigate replacing visit glue with debug info #8948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thestinger opened this issue Sep 3, 2013 · 2 comments
Closed

investigate replacing visit glue with debug info #8948

thestinger opened this issue Sep 3, 2013 · 2 comments
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.)

Comments

@thestinger
Copy link
Contributor

It seems like we could teach the type visitor to walk the debug info, instead of using visit glue. I don't know if this is a worthwhile idea, but it does seem feasible... It depends on how lossy the debugging information is.
@huonw
Copy link
Member

huonw commented Mar 2, 2014

We're currently experimenting with using the Show trait via #[deriving(Show)], rather than the reflection compiler magic.

Using DWARF still seem interesting for debugging printing, e.g. for printing information about things that have no usual method for printing.

@thestinger
Copy link
Contributor Author

Reflection has been removed.

flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 18, 2022
@bors
Auto merge of rust-lang#9156 - Rqnsom:manual_flatten, r=Alexendoo
f78292a 
fix [`manual_flatten`] help texts order

fixes  rust-lang#8948

Whenever suggestion for this lint does not fit in one line,
legacy solution has some unexpected/unhandled behavior:
lint will then generate two help messages which seem to be shown in the wrong order.
The second help message in that case will contain the suggestion.

The first help message always refers to a suggestion message,
and **it should adapt** depending on the location of the suggestion:
- inline suggestion within the error/warning message
- suggestion separated into a second help text

This is my first contribution here, so I hope I didn't miss anything for creating this PR.

changelog: fix [`manual_flatten`] help texts order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huonw @thestinger