Skip to content

Rename finalize to drop #6983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Jun 7, 2013 · 2 comments
Closed

Rename finalize to drop #6983

brson opened this issue Jun 7, 2013 · 2 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Jun 7, 2013

I don't see an issue open for this. The finalize method was only named so because drop was a keyword.
@brson
Copy link
Contributor Author

brson commented Jun 7, 2013

Nominating backcompat.

@bstrie
Copy link
Contributor

bstrie commented Jun 7, 2013

Dupe of #4332. :)

@bstrie bstrie closed this as completed Jun 7, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 8, 2021
@bors
Auto merge of rust-lang#7002 - mgacek8:issue6983_wrong_self_conventio…
38b1fd0 
…n_inside_trait_impls, r=phansch

wrong_self_convention: fix FP inside trait impl for `to_*` method taking `&self`

fixes rust-lang#6983
changelog: `wrong_self_convention`: fix FP inside trait impl for `to_*` method taking `&self`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brson @bstrie