-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Release tarball does not extract correctly with mingw tar #5639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't know yet if it builds correctly. |
It does seem to build fine 7Zip appeared to not have a problem with it. |
This is caused by MinGW tar lacking support for symlinks. It looks like 7-zip will just create a 0-length file. I think modern versions of Windows do have actual symbolic links, but there's probably no easy way to use them when extracting a tarball and it won't work on XP anyway. |
Not critical for 0.6. It works even with the failure, and we recommend using the installer anyway. |
Can someone with a Windows box check if this is still an issue? I guess I'll nominate for milestone 5 (production-ready) while I'm at it. |
accepted for production-ready milestone |
Visiting for triage; nothing to add, I don't have a readily available windows box to test on either. |
The 0.7 tarball extracts fine for me on MinGW/MSYS
|
The previous error was from
So this is currently fixed. Also, clang replaced symlink with real file. So even if we use clang later, the error will not occur again. |
…-cleanup, r=phansch Clarify the documentation of the `unnecessary_mut_passed` lint fixes rust-lang#5433 by replacing "giving" with "passing" changelog: Clarifies documentation for `unnecessary_mut_passed`
This is on rust-win2's mingw shell.
The text was updated successfully, but these errors were encountered: