Skip to content

Release tarball does not extract correctly with mingw tar #5639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brson opened this issue Mar 31, 2013 · 9 comments
Closed

Release tarball does not extract correctly with mingw tar #5639

brson opened this issue Mar 31, 2013 · 9 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. O-windows Operating system: Windows

Comments

@brson
Copy link
Contributor

brson commented Mar 31, 2013

This is on rust-win2's mingw shell.

$ curl http://static.rust-lang.org/dist/rust-0.6.tar.gz > rust-0.6.tar.gz
$ tar xzf rust-0.6.tar.gz
tar: rust-0.6/src/llvm/tools/clang/tools/scan-build/c++-analyzer: Cannot create
symlink to `ccc-analyzer': No such file or directory
tar: Exiting with failure status due to previous errors
@brson
Copy link
Contributor Author

brson commented Mar 31, 2013

I don't know yet if it builds correctly.

@brson
Copy link
Contributor Author

brson commented Mar 31, 2013

It does seem to build fine

7Zip appeared to not have a problem with it.

@thestinger
Copy link
Contributor

This is caused by MinGW tar lacking support for symlinks. It looks like 7-zip will just create a 0-length file. I think modern versions of Windows do have actual symbolic links, but there's probably no easy way to use them when extracting a tarball and it won't work on XP anyway.

@brson
Copy link
Contributor Author

brson commented Apr 1, 2013

Not critical for 0.6. It works even with the failure, and we recommend using the installer anyway.

@catamorphism
Copy link
Contributor

Can someone with a Windows box check if this is still an issue? I guess I'll nominate for milestone 5 (production-ready) while I'm at it.

@graydon
Copy link
Contributor

graydon commented May 23, 2013

accepted for production-ready milestone

@emberian
Copy link
Member

emberian commented Aug 5, 2013

Visiting for triage; nothing to add, I don't have a readily available windows box to test on either.

@darkf
Copy link
Contributor

darkf commented Aug 6, 2013

The 0.7 tarball extracts fine for me on MinGW/MSYS

$ tar --version
tar (GNU tar) 1.23
Copyright (C) 2010 Free Software Foundation, Inc.

@klutzy
Copy link
Contributor

klutzy commented Oct 7, 2013

The previous error was from src/llvm/tools/clang, which is not present now. No tar error with 0.8 tarball.

$ curl http://static.rust-lang.org/dist/rust-0.8.tar.gz > 8.tgz
$ tar zxf 8.tgz
$ tar --version
tar (GNU tar) 1.23
...

So this is currently fixed.

Also, clang replaced symlink with real file. So even if we use clang later, the error will not occur again.

flip1995 pushed a commit to flip1995/rust that referenced this issue May 27, 2020
…-cleanup, r=phansch

Clarify the documentation of the `unnecessary_mut_passed` lint

fixes rust-lang#5433 by replacing "giving" with "passing"

changelog: Clarifies documentation for `unnecessary_mut_passed`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. O-windows Operating system: Windows
Projects
None yet
Development

No branches or pull requests

7 participants