enum discriminant should only be as big as needed #5024
Comments
|
See #1647 for the past discussion. |
|
Yeah this is a dupe. We have at least 4 bugs open on this. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
May 2, 2020
…lip1995 Match wild err arm improvements This lint should trigger on other identifiers which have `_` prefix (such as `_e`) and only if they are unused in the panic block. _Note_: the `is_unused` function is greatly inspired from `pat_is_wild` function in [loops lints](https://github.com/rust-lang/rust-clippy/blob/43ac9416d935942d6c7d2b2e0c876c551652c4ec/clippy_lints/src/loops.rs#L1689). I've been considering doing some refactoring, maybe in utils. Maybe this PR or a new one. What do you think ? fixes rust-lang#5024 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I don't think there's any need to make these 64-bit, or even require that they be 32-bit. It's somewhat surprising how big stuff like
Option<()>is at the moment. It's very painful for stuff likeSmallIntMapandDequethat use~[Option<T>], and for implementing set types as wrappers around map types.For compatibility with C code, a
#[discriminant = c_int]attribute can be offered to choose whatever primitive integer type is desired (C++11 has this feature too, asclass enum foo: uint8_t)The text was updated successfully, but these errors were encountered: