-
Notifications
You must be signed in to change notification settings - Fork 13.4k
configure message re: rustbuild assumes curr dir is source dir #38251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It probably makes sense to just copy |
@petrochenkov oh indeed that may make sense, since I just noticed that the |
pnkfelix
added a commit
to pnkfelix/rust
that referenced
this issue
Dec 8, 2016
bors
added a commit
that referenced
this issue
Dec 11, 2016
…xcrichton Make configure message re x.py not assume build dir == src dir Fix #38251 but perhaps not BEST fix for it. As driveby, fix copyright year in `Makefile.in`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If you build rust out of tree, the configure script currently prints a message:
The problem is that if I am running
configure
in a directory other than the root of the source directory, then the instruction to runpython x.py --help
will not work.Furthermore, as a user who has often encountered software not supporting out-of-tree builds, when I encounter a message like that, my first instinct is to assume that this software does not support out of tree builds.
I recommend that the configure script detect whether the current directory is not the root of the Rust source directory, and if so, use
${CFG_SRC_DIR}/x.py
as the path to the python script instead of justx.py
.The text was updated successfully, but these errors were encountered: