Skip to content

configure message re: rustbuild assumes curr dir is source dir #38251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pnkfelix opened this issue Dec 8, 2016 · 3 comments · Fixed by #38252
Closed

configure message re: rustbuild assumes curr dir is source dir #38251

pnkfelix opened this issue Dec 8, 2016 · 3 comments · Fixed by #38252

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Dec 8, 2016

If you build rust out of tree, the configure script currently prints a message:

onfigure: NOTE you have now configured rust to use a rewritten build system
configure:      called rustbuild, and as a result this may have bugs that 
configure:      you did not see before. If you experience any issues you can
configure:      go back to the old build system with --disable-rustbuild and
configure:      please feel free to report any bugs!
configure: 
configure: run `python x.py --help`

The problem is that if I am running configure in a directory other than the root of the source directory, then the instruction to run python x.py --help will not work.

Furthermore, as a user who has often encountered software not supporting out-of-tree builds, when I encounter a message like that, my first instinct is to assume that this software does not support out of tree builds.

I recommend that the configure script detect whether the current directory is not the root of the Rust source directory, and if so, use ${CFG_SRC_DIR}/x.py as the path to the python script instead of just x.py.

@pnkfelix
Copy link
Member Author

pnkfelix commented Dec 8, 2016

cc @alexcrichton

@petrochenkov
Copy link
Contributor

It probably makes sense to just copy x.py into the build directory on first run so it could be invoked without any prefixes.

@pnkfelix
Copy link
Member Author

pnkfelix commented Dec 8, 2016

@petrochenkov oh indeed that may make sense, since I just noticed that the Makefile.in also assumes that x.py is present in the build directory...

pnkfelix added a commit to pnkfelix/rust that referenced this issue Dec 8, 2016
bors added a commit that referenced this issue Dec 11, 2016
…xcrichton

Make configure message re x.py not assume build dir == src dir

Fix #38251 but perhaps not BEST fix for it.

As driveby, fix copyright year in `Makefile.in`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants