Skip to content

Stack vs. Heap documentation uses 0 as a memory location #29852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
huonw opened this issue Nov 16, 2015 · 0 comments
Closed

Stack vs. Heap documentation uses 0 as a memory location #29852

huonw opened this issue Nov 16, 2015 · 0 comments

Comments

@huonw
Copy link
Member

huonw commented Nov 16, 2015

The stack in https://doc.rust-lang.org/stable/book/the-stack-and-the-heap.html starts at 0, which means the Option<ptr> optimisation would be invalid.
@huonw huonw added the A-docs label Nov 16, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this issue Nov 16, 2015
@steveklabnik
Reaffirm that this is an abstraction
54db4d6 
Fixes rust-lang#29853
Fixes rust-lang#29852

While these points are true, we're not going for 100% accuracy here,
this is introductory material. Changing these things would be more
confusing, but it is important to note that we're presenting an
abstraction here.
@steveklabnik steveklabnik mentioned this issue Nov 16, 2015
Merged
bors added a commit that referenced this issue Nov 17, 2015
@bors
Auto merge of #29860 - steveklabnik:stackheapfixes, r=huonw
3037b29 
Fixes #29853
Fixes #29852

While these points are true, we're not going for 100% accuracy here,
this is introductory material. Changing these things would be more
confusing, but it is important to note that we're presenting an
abstraction here.

r? @huonw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huonw