Skip to content

Confusing error messages with ||-closures vs binary "||" #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bblum opened this issue Jul 2, 2012 · 0 comments
Closed

Confusing error messages with ||-closures vs binary "||" #2783

bblum opened this issue Jul 2, 2012 · 0 comments
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@bblum
Copy link
Contributor

bblum commented Jul 2, 2012 

fn foo(f: fn()) { f() }
fn main() {
    foo || {}; 
}

produces:

shit.rs:4:4: 4:13 error: binary operation || cannot be applied to type `extern fn(fn())

It'd be nice if it checked if the thing on the left had type "fn(fn * -> *) -> *", and said "Did you mean do foo || ... ?"
mitsuhiko added a commit to mitsuhiko/rust that referenced this issue Jul 2, 2012
@mitsuhiko
Provide a better error message for a common error of a missing do key…
0447e61 
…word. Closes rust-lang#2783
@mitsuhiko mitsuhiko mentioned this issue Jul 2, 2012
Closed
mitsuhiko added a commit to mitsuhiko/rust that referenced this issue Jul 3, 2012
@mitsuhiko
Implemented better error message for missing do statements.
722eaf2 
This fixes rust-lang#2783 for the case where an empty double pipe
symbol is being used without a do keyword.
@mitsuhiko mitsuhiko mentioned this issue Jul 3, 2012
Closed
@brson brson closed this as completed in 5bd9d6e Jul 3, 2012
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@remi-delmas-3000 @adpaco-aws
Bump version 0.37.0 (rust-lang#2783)
c7c0f18 
Co-authored-by: Remi Delmas <[email protected]>
Co-authored-by: Adrian Palacios <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implemented better error message for missing do statements. mitsuhiko/rust
2 participants
@brson @bblum