Skip to content

Eliminate need for -fno-strict-aliasing in lock_free_queue.h #2701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
graydon opened this issue Jun 21, 2012 · 2 comments
Closed

Eliminate need for -fno-strict-aliasing in lock_free_queue.h #2701

graydon opened this issue Jun 21, 2012 · 2 comments
Assignees
@brson
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@graydon
Copy link
Contributor

graydon commented Jun 21, 2012

As per fixme.
@brson
Copy link
Contributor

brson commented Jun 21, 2012

We don't even turn on -fno-strict-aliasing - the line in platform.mk that tries to do it has a typo - nor do we use lock_free_queue or know it to be unbroken. It should probably just be deleted.

brson added a commit that referenced this issue Jun 25, 2012
@brson
rt: Remove lock_free_queue. Unused. Issue #2701
3d0826b
brson added a commit that referenced this issue Jun 25, 2012
@brson
build: Remove bogus -fno-strict-aliasing flags. Issue #2701
8910b2f
@ghost ghost assigned brson Jun 25, 2012
@brson
Copy link
Contributor

brson commented Jun 27, 2012

Done.

@brson brson closed this as completed Jun 27, 2012
RalfJung pushed a commit to RalfJung/rust that referenced this issue Nov 27, 2022
@bors
Auto merge of rust-lang#2701 - RalfJung:smoke, r=RalfJung
9f8df93 
run_tests_minimal: actually run the smoke test on the desired target
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2701 - RalfJung:smoke, r=RalfJung
e1842ba 
run_tests_minimal: actually run the smoke test on the desired target
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brson brson

Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graydon @brson