Skip to content

Handle failure properly in rust_sched_loop::schedule_task #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catamorphism opened this issue Jun 21, 2012 · 2 comments
Closed

Handle failure properly in rust_sched_loop::schedule_task #2695

catamorphism opened this issue Jun 21, 2012 · 2 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Milestone
old 1.0 milestone

Comments

@catamorphism
Copy link
Contributor

There's a commented-out assertion with a FIXME: "in the face of failing tasks, this is not always right."
@bblum
Copy link
Contributor

bblum commented Jun 27, 2012

I'd take it, but a look over doesn't immediately reveal why. @brson ?

@brson
Copy link
Contributor

brson commented Jun 27, 2012

That FIXME is ancient, referring to an invariant maintained by a commented-out assert that references a variable that no longer exists. I think it is just totally bogus now.

RalfJung pushed a commit to RalfJung/rust that referenced this issue Nov 27, 2022
@bors
Auto merge of rust-lang#2695 - RalfJung:ci-pretty, r=RalfJung
b3e4402 
prettify our CI logs
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2695 - RalfJung:ci-pretty, r=RalfJung
e6b392b 
prettify our CI logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
old 1.0 milestone
Development

No branches or pull requests
3 participants
@brson @catamorphism @bblum