Skip to content

Determine whether morestack needs to save %rax #2685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catamorphism opened this issue Jun 21, 2012 · 1 comment
Closed

Determine whether morestack needs to save %rax #2685

catamorphism opened this issue Jun 21, 2012 · 1 comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Milestone
old 1.0 milestone

Comments

@catamorphism
Copy link
Contributor

As per a FIXME: "libgcc also saves rax. not sure if we need to"
@brson
Copy link
Contributor

brson commented Jun 25, 2012

The answer is probably 'no'. I believe %rax is used for passing arguments to 'nested functions' which I gather are a terrible GCC feature that we should not support.

RalfJung pushed a commit to RalfJung/rust that referenced this issue Nov 27, 2022
@bors
Auto merge of rust-lang#2685 - Nilstrieb:cargo-miri-wasm, r=RalfJung
a83b105 
Use `.wasm` extension when building for wasm in cargo-miri

WASM uses the `.wasm` file extension for its binaries (just like how windows uses `.exe`), so we need to set that as well.

I'm not sure whether gating this behind the wasm target is a good idea, maybe it makes more sense to always do it just like on windows.
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2685 - Nilstrieb:cargo-miri-wasm, r=RalfJung
582cd61 
Use `.wasm` extension when building for wasm in cargo-miri

WASM uses the `.wasm` file extension for its binaries (just like how windows uses `.exe`), so we need to set that as well.

I'm not sure whether gating this behind the wasm target is a good idea, maybe it makes more sense to always do it just like on windows.
celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@zhassan-aws
Upgrade Rust toolchin to 2023-08-07 (rust-lang#2685)
5a9c933
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Projects
None yet
Milestone
old 1.0 milestone
Development

No branches or pull requests
2 participants
@brson @catamorphism