Skip to content

Document suffix inference #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lkuper opened this issue Jun 20, 2012 · 1 comment
Closed

Document suffix inference #2646

lkuper opened this issue Jun 20, 2012 · 1 comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
0.3

Comments

@lkuper
Copy link
Contributor

lkuper commented Jun 20, 2012

The tutorial and manual don't say anything about suffix inference, and they should for 0.3. (Assigning to myself.)
@ghost ghost assigned lkuper Jun 20, 2012
@lkuper
Copy link
Contributor Author

lkuper commented Jun 21, 2012

1df6ddd closes this.

@lkuper lkuper closed this as completed Jun 21, 2012
@lkuper lkuper removed their assignment Jun 16, 2014
RalfJung pushed a commit to RalfJung/rust that referenced this issue Dec 24, 2022
@bors
Auto merge of rust-lang#2646 - saethlin:data-race-spans, r=RalfJung
245357f 
Data race spans

Fixes rust-lang/miri#2205

This adds output to data race errors very similar to the spans we emit for Stacked Borrows errors. For example, from our test suite:
```
help: The Atomic Load on thread `<unnamed>` is here
  --> tests/fail/data_race/atomic_read_na_write_race1.rs:23:13
   |
23 | ...   (&*c.0).load(Ordering::SeqCst) //~ ERROR: Data race detected between Atomic Load on thread `<unnamed>` and Write o...
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: The Write on thread `<unnamed>` is here
  --> tests/fail/data_race/atomic_read_na_write_race1.rs:19:13
   |
19 |             *(c.0 as *mut usize) = 32;
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^```
```

Because of rust-lang/miri#2647 this comes without a perf regression, according to our benchmarks.
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2646 - saethlin:data-race-spans, r=RalfJung
4ec960f 
Data race spans

Fixes rust-lang/miri#2205

This adds output to data race errors very similar to the spans we emit for Stacked Borrows errors. For example, from our test suite:
```
help: The Atomic Load on thread `<unnamed>` is here
  --> tests/fail/data_race/atomic_read_na_write_race1.rs:23:13
   |
23 | ...   (&*c.0).load(Ordering::SeqCst) //~ ERROR: Data race detected between Atomic Load on thread `<unnamed>` and Write o...
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: The Write on thread `<unnamed>` is here
  --> tests/fail/data_race/atomic_read_na_write_race1.rs:19:13
   |
19 |             *(c.0 as *mut usize) = 32;
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^```
```

Because of rust-lang/miri#2647 this comes without a perf regression, according to our benchmarks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
0.3
Development

No branches or pull requests
1 participant
@lkuper