Skip to content

In rustdoc::reexport_pass::build_reexport_def_map, use a parallel fold #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
catamorphism opened this issue Jun 14, 2012 · 1 comment
Closed

In rustdoc::reexport_pass::build_reexport_def_map, use a parallel fold #2597

catamorphism opened this issue Jun 14, 2012 · 1 comment
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Milestone
old 1.0 milestone

Comments

@catamorphism
Copy link
Contributor

as per a FIXME. (I tried making this change, but it didn't combine because hash maps aren't sendable.)
@catamorphism
Copy link
Contributor Author

This module no longer exists. O frabjous day!

jaisnan pushed a commit to jaisnan/rust-dev that referenced this issue Jul 29, 2024
@pi314mm
Change ensures into closures (rust-lang#3207)
9f4fc30 
This change now separates the front facing "result" name and the
internal facing "result_kani_internal" ident where the user can specify
with the keyword "result" but then the system replaces this with the
internal representation.

If the user chooses to use a different variable name than result, this
now supports the syntax of
`#[kani::ensures(|result_var| expr)]`
where result_var can be any arbitrary name.

For example, the following test now works:
```
#[kani::ensures(|banana : &u32| *banana == a.wrapping_add(b))]
fn simple_addition(a: u32, b: u32) -> u32 {
    return a.wrapping_add(b);
}
```

In addition, the string "result_kani_internal" is now a global constant
and can be updated in a single place if needed.

Resolves rust-lang#2597 since the user can specify the variable name they want
within the ensures binding

An important change is that the result is now a pass by reference
instead, so as in the example an `&u32` instead of `u32`

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.

---------

Co-authored-by: Matias Scharager <[email protected]>
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 3, 2025
@Jarcho
set the applicability of op_ref to MachineApplicable (rust-lang#1…
d993432 
…4438)

rust-lang#2597 appears to be already resolved, so the applicability of `op_ref`
can be set to `MachineApplicable`.

close rust-lang#2597

changelog: [`op_ref`]: set the applicability to `MachineApplicable`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-slow Issue: Problems and improvements with respect to performance of generated code. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
old 1.0 milestone
Development

No branches or pull requests
1 participant
@catamorphism