Skip to content

various eof type signatures are not consistent #16577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
steveklabnik opened this issue Aug 18, 2014 · 1 comment
Closed

various eof type signatures are not consistent #16577

steveklabnik opened this issue Aug 18, 2014 · 1 comment
Assignees
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@steveklabnik
Copy link
Member

$ git grep "fn eof"
src/libnative/io/util.rs:pub fn eof() -> IoError {
src/libserialize/json.rs:    fn eof(&self) -> bool { self.ch.is_none() }
src/libstd/io/fs.rs:    pub fn eof(&self) -> bool {
src/libstd/io/mem.rs:    pub fn eof(&self) -> bool { self.pos >= self.buf.len() }
src/libstd/io/mem.rs:    pub fn eof(&self) -> bool { self.pos >= self.buf.len() }
src/libsyntax/print/pp.rs:pub fn eof(p: &mut Printer) -> io::IoResult<()> { p.pretty_...

One IoError, four bools, and one IoResult.

cc @aturon

@aturon aturon self-assigned this Aug 26, 2014
@aturon
Copy link
Member

aturon commented Mar 26, 2015

I think there aren't any problems here in terms of public, stable APIs, so I'm going to go ahead and close this out. We can address any remaining signatures as part of the normal stabilization process.

@aturon aturon closed this as completed Mar 26, 2015
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 18, 2024
…e-7, r=Veykril

internal: Migrate assists to the structured snippet API, part 7/7

Continuing from rust-lang#16467

Migrates the following assists:

- `generate_trait_from_impl`

This adds `add_placeholder_snippet_group`, which adds a group of placeholder snippets which are linked together and allows for renaming generated items without going through a separate rename step.

This also removes the last usages of `SourceChangeBuilder::{insert,replace}_snippet`, as all assists have finally been migrated to the structured snippet versions of those methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

2 participants