-
Notifications
You must be signed in to change notification settings - Fork 13.3k
regression: error[E0308]: mismatched types
for is_multiple_of
#140020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is probably expected fallout from #128101 (still open?) and #137383, and we can just close if the impact is considered acceptable. For |
cc @rust-lang/libs-api |
Yes, this was expected. |
We discussed this in the @rust-lang/libs meeting and confirm that this is an expected regression. We don't plan to roll it back considering the relatively limited fallout. |
<!-- Reference any GitHub issues resolved by this PR --> Closes # ## Introduced changes <!-- A brief description of the changes --> Interface of `is_multiple_of` changed in rust 1.87.0. This is a know regression that won't be resolved, see rust-lang/rust#140020 Due to that, `cairo_vm` no longer compiles on later rust version. Until they upgrade and we upgrade our version of `cairo_vm`, then we have to stay at rust 1.86.0 Issue to remove the pinned version #3351 ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md`
Crater returned multiple cases of mismatched types for
x.is_multiple_of(&y)
, sincenum_integer::Integer
's method uses references and the new inherent methods are by value.Version it worked on
It most recently worked on: 1.86.0
Version with regression
Using
1.87.0-beta.4
in crater #139827.@rustbot modify labels: +regression-from-stable-to-beta -regression-untriaged
The text was updated successfully, but these errors were encountered: