Skip to content

Target sanity-check in bootstrap incorrect when doing a local-rebuild #130242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bjorn3 opened this issue Sep 11, 2024 · 1 comment · Fixed by #130261
Closed

Target sanity-check in bootstrap incorrect when doing a local-rebuild #130242

bjorn3 opened this issue Sep 11, 2024 · 1 comment · Fixed by #130261
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@bjorn3
Copy link
Member

bjorn3 commented Sep 11, 2024

When doing a local-rebuild, the bootstrap compiler is supposed to be functionally identical to the compiler we are building and thus supports all newly introduced targets. As such all targets in the STAGE0_MISSING_TARGETS list would actually be supported. With current nightly doing a local-rebuild results in the following error due to this issue:

Following targets supported from the stage0 compiler, please remove them from `STAGE0_MISSING_TARGETS` list.
  armv7-rtems-eabihf
Build completed unsuccessfully in 0:00:28

We should probably set BOOTSTRAP_SKIP_TARGET_SANITY=1 unconditionally for all local-rebuilds, or alternatively pretend STAGE0_MISSING_TARGETS is empty.
@bjorn3 bjorn3 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Sep 11, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 11, 2024
@bjorn3
Copy link
Member Author

bjorn3 commented Sep 11, 2024

Worked around this in rust-lang/rustc_codegen_cranelift@ade0e38.

@onur-ozkan onur-ozkan removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 12, 2024
@onur-ozkan onur-ozkan mentioned this issue Sep 12, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 12, 2024
@bors
Auto merge of rust-lang#130261 - onur-ozkan:rust-lang#130242, r=<try>
f9a4006 
skip target sanity check when it's a `local-rebuild`

Running the stage0 target sanity check on the newly built compiler can result in errors and incorrect assumptions.

Resolves rust-lang#130242

try-job: dist-x86_64-linux
@bors bors closed this as completed in 26bda05 Sep 13, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Sep 13, 2024
@rust-timer
Unrolled build for rust-lang#130261
10e5c7e 
Rollup merge of rust-lang#130261 - onur-ozkan:rust-lang#130242, r=Kobzol

skip target sanity check when it's a `local-rebuild`

Running the stage0 target sanity check on the newly built compiler can result in errors and incorrect assumptions.

Resolves rust-lang#130242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

skip target sanity check when it's a local-rebuild onur-ozkan/rust
4 participants
@bjorn3 @onur-ozkan @rustbot and others