Skip to content

rustpkg Initialize BuildContext/WorkCache later in the build process #11474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nielsle opened this issue Jan 11, 2014 · 0 comments
Closed

rustpkg Initialize BuildContext/WorkCache later in the build process #11474

nielsle opened this issue Jan 11, 2014 · 0 comments

Comments

@nielsle
Copy link
Contributor

nielsle commented Jan 11, 2014

The BuildContext mainly consists of WorkCache, and that is not needed for commands like "rustpkg init". Therefore it would be nice to initialize BuildContext later in the build process.

Right now "rustpkg init" calls a method on the trait CtxMethods which is implemented by BuildContext, so you cannot run "rustpkg init" without initializing BuildContexts, so we should start out replacing the methods of CtxMethods with functions.

This issue keeps track of the work and resulting cleanups.

PS: I started out trying to do everything in one pull request, but it became a little too long so I retracted it again #11379
@nielsle nielsle mentioned this issue Jan 11, 2014
Closed
@nielsle nielsle closed this as completed Jan 11, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Sep 12, 2023
@bors
Auto merge of rust-lang#11477 - samueltardieu:11474, r=xFrednet
98363cb 
Auto deref does not apply on union field

changelog: [`explicit_auto_deref`]: do not suggest propose to auto-dereference an union field

Fix rust-lang#11474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nielsle