Skip to content

Native comm tests are disabled on Windows #11003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexcrichton opened this issue Dec 16, 2013 · 0 comments · Fixed by #11199
Closed

Native comm tests are disabled on Windows #11003

alexcrichton opened this issue Dec 16, 2013 · 0 comments · Fixed by #11199

Comments

@alexcrichton
Copy link
Member

I'm disabling the native std::comm tests on windows. I'm suspecting that our usage of SetEvent and friends are not matching the semantics of a unix condition variable, or something related like that.

Disabling for now, will investigate later (plus perhaps we could just use the windows condition variables if we don't want to support XP).
@alexcrichton alexcrichton mentioned this issue Dec 29, 2013
Merged
bors added a commit that referenced this issue Dec 30, 2013
@bors
auto merge of #11199 : alexcrichton/rust/windows-isnt-waiting, r=pcwa…
1502b11 
…lton

Turns out with an argument of 0 the function always returns immediately!

Closes #11003
nrc pushed a commit to nrc/rust that referenced this issue Jan 2, 2014
@alexcrichton @nrc
Actually block in a windows cvar
945268f 
Turns out with an argument of 0 the function always returns immediately!

Closes rust-lang#11003
@lifthrasiir lifthrasiir mentioned this issue Jan 31, 2014
Closed
flip1995 pushed a commit to flip1995/rust that referenced this issue Jul 31, 2023
@bors
Auto merge of rust-lang#11003 - Centri3:absolute_path, r=Alexendoo,bl…
58df1e6 
…yxyas

New lint [`absolute_paths`]

Closes rust-lang#10568

Maybe we should make the max segments allowed a configuration option? I see quite a bit of 3-segment paths in clippy, and while I think only really `<mod/type>::<item>` or `<item>` should be (usually) used but anything above may be too widespread 😕

PS, despite this being "max segments allowed" it only lints if it's absolute, as is the point of the lint, e.g., `std::io::ErrorKind::etc` is linted but `io::ErrorKind::NotFound::etc` isn't

changelog: New lint [`absolute_paths`]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Actually block in a windows cvar alexcrichton/rust
1 participant
@alexcrichton