Migrate from highfive to triagebot #9963
Conversation
|
r? @Jarcho (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @flip1995 |
|
I'd be interested in the context of this change. Is the goal to deprecate rust-highfive? Having the config in this repo will make it easier for us to have control, so I can definitely see and advantage in this :) |
ehuss
changed the title
|
Yes, we are removing highfive. BTW, just to be clear, please do not merge this. This requires infra to be involved. |
|
Interesting, We'll miss you @rust-highfive <3 I've marked the PR as a draft, to ensure that it won't get merged :) |
ehuss
force-pushed
the
highfive-triagebot
branch
from
1c81fa6 to
13dfbb2
Compare
ehuss
changed the title
|
This should be ready to go. |
| # Allows shortcuts like `@rustbot ready` | ||
| # | ||
| # See https://github.com/rust-lang/triagebot/wiki/Shortcuts | ||
| [shortcut] | ||
|
|
||
| [assign] | ||
| contributing_url = "https://github.com/rust-lang/rust-clippy/blob/master/CONTRIBUTING.md" |
There was a problem hiding this comment.
What does this field do? Like where is it mentioned? :)
There was a problem hiding this comment.
In the welcome message to new users. It looks like this. There is documentation for the assignment options at https://github.com/rust-lang/triagebot/wiki/Assignment#additional-new-pr-trigger-options.
|
Alright, thank you. Then this looks good to me, let's see if everything works smoothly. I'll monitor new incoming PRs to ensure that someone gets assigned to each of them. Thank you for the help! @bors r+ |
Migrate from highfive to triagebot This migrates this repository from using the highfive bot to using triagebot (aka rustbot). This should not be merged without coordinating the removal of the highfive webhook and/or merging rust-lang/highfive#435.
|
💔 Test failed - checks-action_test |
|
@bors retry |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
Hey @ehuss, after this PR new PRs have stopped receiving the You included these lines in a previous version, but removed them again: [autolabel."S-waiting-on-review"]
new_pr = trueWas there a reason for this change and would it be enough to add to the config file? |
|
Oh, yea, sure! Sorry about that, I posted #9985 to add it. I was looking at the homu config and noticed clippy wasn't using autolabels and for some reason didn't think it was being used here. |
Add S-waiting-on-review autolabel. This adds the S-waiting-on-review autolabel feature for new PRs. This was previously handled by highfive, but I neglected to include it in #9963. changelog: none
|
No problem, thank you for adding it again :) |
This migrates this repository from using the highfive bot to using triagebot (aka rustbot).
This should not be merged without coordinating the removal of the highfive webhook and/or merging rust-lang/highfive#435.
changelog: none