-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Move mini-macro to tests/ui/auxilary #7285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
} | ||
|
||
#[derive(ClippyMiniMacroTest, Debug)] | ||
struct Foo; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted this for convenience since /crashes has a separate auxilary folder. The test is redundant and history shows no evidence that it ever produced an ICE (see #3743).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also can't find the reason why this exists. Probably to check that the derive doesn't produce an ICE. But since we use this in other tests too, deleting this test should be fine.
} | ||
|
||
#[derive(ClippyMiniMacroTest, Debug)] | ||
struct Foo; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also can't find the reason why this exists. Probably to check that the derive doesn't produce an ICE. But since we use this in other tests too, deleting this test should be fine.
@bors r+ Thanks! This is long overdue. |
📌 Commit 6c54f61 has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
changelog: none
Merges
/mini-macro
into/tests/ui/auxilary/proc_macro_derive.rs
.The mini-macro crate is an artifact of the distant past. A lot has changed (#2284) and it doesn't make sense as a top-level crate anymore. Especially since we can use the auxilary folder to accompolish the same thing.