Skip to content

Move mini-macro to tests/ui/auxilary #7285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2021

Conversation

camsteffen
Copy link
Contributor

changelog: none

Merges /mini-macro into /tests/ui/auxilary/proc_macro_derive.rs.

The mini-macro crate is an artifact of the distant past. A lot has changed (#2284) and it doesn't make sense as a top-level crate anymore. Especially since we can use the auxilary folder to accompolish the same thing.

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 27, 2021
}

#[derive(ClippyMiniMacroTest, Debug)]
struct Foo;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted this for convenience since /crashes has a separate auxilary folder. The test is redundant and history shows no evidence that it ever produced an ICE (see #3743).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also can't find the reason why this exists. Probably to check that the derive doesn't produce an ICE. But since we use this in other tests too, deleting this test should be fine.

}

#[derive(ClippyMiniMacroTest, Debug)]
struct Foo;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also can't find the reason why this exists. Probably to check that the derive doesn't produce an ICE. But since we use this in other tests too, deleting this test should be fine.

@flip1995
Copy link
Member

@bors r+

Thanks! This is long overdue.

@bors
Copy link
Contributor

bors commented May 27, 2021

📌 Commit 6c54f61 has been approved by flip1995

@bors
Copy link
Contributor

bors commented May 27, 2021

⌛ Testing commit 6c54f61 with merge 543a8a6...

@bors
Copy link
Contributor

bors commented May 27, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 543a8a6 to master...

@bors bors merged commit 543a8a6 into rust-lang:master May 27, 2021
@camsteffen camsteffen deleted the mini-macro-move branch July 8, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants