cargo-ui tests: check that <dir>/src exists before processing test #5662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I also realized, that this doesn't work in the rustc test suite. Are you motivated to look into that? If you need help to set up the rustc test suite, feel free to ask. r=me with @matthiaskrgr comment addressed. |
Sure, I'll take a look at it in the coming days |
flip1995
added
S-waiting-on-author
ebroto
force-pushed
the
cargo_tests_invalid_crate
branch
from
f10ca00 to
27c0166
Compare
ebroto
force-pushed
the
cargo_tests_invalid_crate
branch
from
27c0166 to
14e9100
Compare
|
@bors r+ |
|
📌 Commit 14e9100 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that I had fixed this in a PR I closed some days ago (#5643).
Before this change, cargo UI tests could fail when switching between branches if the previous branch had a test that the current branch does not have. The directory is not removed when switching because an ignored
Cargo.lockfile exists, and the code was trying to reach$DIR/srcunconditionally.This change will just skip a directory that has no
srcsubdirectory.changelog: none