Fix #2927 #3056
Merged
Fix #2927 #3056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
reviewed
Aug 15, 2018
| @@ -142,6 +142,11 @@ fn underscores_and_numbers() { | |||
| let _1_ok= 1; | |||
| } | |||
|
|
|||
| fn issue2927() { | |||
There was a problem hiding this comment.
This example does not acctually replicate the issue: http://play.rust-lang.org/?gist=48e4192bd06e619f1c13858e591ffd45&version=stable&mode=debug&edition=2015
There was a problem hiding this comment.
The lint is allow by default. Here is a fixed version: http://play.rust-lang.org/?gist=b247b042cb0407db292ba9d501bd6d1a&version=stable&mode=debug&edition=2015
There was a problem hiding this comment.
Oh... I feel stupid now XD
oli-obk
reviewed
Aug 15, 2018
clippy_lints/src/lib.rs
Outdated
|
|
||
| pub fn register_pre_expansion_lints(session: &rustc::session::Session, store: &mut rustc::lint::LintStore, conf: &Conf) { |
There was a problem hiding this comment.
can you move this function above the read_conf function to reduce the diff size?
|
Thanks! |
ghost
mentioned this pull request
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.