Fulfill the lint expectation even if allowed at the type level #14604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
r? @Alexendoo |
Alexendoo
reviewed
Apr 13, 2025
samueltardieu
force-pushed
the
fulfill-len-without-is-empty
branch
from
4b01dbb to
1053eb0
Compare
`clippy::len_without_is_empty` can be allowed at the type declaration site, and this will prevent the lint from triggering even though the lint is shown on the `len()` method definition. This allows the lint to be expected even though it is allowed at the type declaration site.
samueltardieu
force-pushed
the
fulfill-len-without-is-empty
branch
from
1053eb0 to
327da45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clippy::len_without_is_emptycan be allowed at the type declaration site, and this will prevent the lint from triggering even though the lint is shown on thelen()method definition.This allows the lint to be expected even though it is allowed at the type declaration site.
changelog: [
len_without_is_empty]: the lint can now be#[expect]ed on thelen()method even when it is#[allow]ed on the definining type.Fixes #14597