Skip to content

Add the allow_exact_repetitions option to the module_name_repetititions lint #14261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

SLUCHABLUB
Copy link
Contributor

@SLUCHABLUB SLUCHABLUB commented Feb 20, 2025

changelog: [module_name_repetitions]: new configuration option allow_exact_repetitions, enabled by default

Closes #14226

@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @llogiq (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 20, 2025
@samueltardieu
Copy link
Contributor

changelog: new configuration entry: [allow_exact_repetitions]

The changelog should contain the affected lint name, such as in

changelog: [`module_name_repetitions`]: new configuration option `allow_exact_repetitions`, enabled by default

@rustbot

This comment has been minimized.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 31, 2025
@llogiq
Copy link
Contributor

llogiq commented May 12, 2025

Apart from the merge conflicts, this looks good to me. Please rebase and ping me.

@SLUCHABLUB
Copy link
Contributor Author

@llogiq, I have now rebased.

@llogiq llogiq added this pull request to the merge queue May 14, 2025
@llogiq
Copy link
Contributor

llogiq commented May 14, 2025

Thank you!

Merged via the queue into rust-lang:master with commit 1a864f3 May 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint againts items with the same names as their modules
4 participants