Skip to content

pulldown-cmark: don't pull getopts dep #13562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2024
Merged

pulldown-cmark: don't pull getopts dep #13562

merged 1 commit into from
Oct 18, 2024

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Oct 18, 2024

Don't pull getopts, as it unused. Noticed in rust-lang/rust#131892

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Oct 18, 2024

r? @Manishearth

rustbot has assigned @Manishearth.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 18, 2024
@flip1995
Copy link
Member

I also noticed that, but thought "whatever, rustc uses that anyway".

But fewer needless features, the better

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Oct 18, 2024

📌 Commit 2c3a34a has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 18, 2024

⌛ Testing commit 2c3a34a with merge 47effe4...

@bors
Copy link
Contributor

bors commented Oct 18, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing 47effe4 to master...

@bors bors merged commit 47effe4 into rust-lang:master Oct 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants