Don't trigger const_is_empty for inline const assertions
#13558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
dswij
approved these changes
Oct 19, 2024
|
Thank you! @bors r+ |
bors
added a commit
that referenced
this pull request
Oct 20, 2024
Don't trigger `const_is_empty` for inline const assertions Close #13106 Considered case was described [here](#13114 (comment)) changelog [`const_is_empty`]: skip const_is_empty for inline const assertions
|
💔 Test failed - checks-action_test |
|
@bors retry |
|
@alex-semenyuk: 🔑 Insufficient privileges: not in try users |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Oct 22, 2024
Don't trigger `const_is_empty` for inline const assertions Close #13106 Considered case was described [here](#13114 (comment)) changelog [`const_is_empty`]: skip const_is_empty for inline const assertions
|
💔 Test failed - checks-action_test |
|
@dswij need one more attempt or is it something with the PR |
|
The PR description needs to contain exactly |
|
Thanks for pointing. Now should be ok. |
|
@bors r=dswij |
|
💡 This pull request was already approved, no need to approve it again.
|
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #13106
Considered case was described here
changelog: [
const_is_empty]: skip const_is_empty for inline const assertions