Skip to content

Fix wrong suggestion for single_element_loop where parens were missing #13117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

GuillaumeGomez
Copy link
Member

Fixes #12782.

changelog: Fix missing parens in single_element_loop suggestion

@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2024

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 17, 2024
@GuillaumeGomez GuillaumeGomez force-pushed the fix-single_element_loop-suggestion branch from 036df55 to b0b953d Compare July 17, 2024 19:06
@GuillaumeGomez
Copy link
Member Author

Fix merge conflict that appeared seconds after I opened the PR. XD

@GuillaumeGomez GuillaumeGomez force-pushed the fix-single_element_loop-suggestion branch from b0b953d to 4762b99 Compare July 18, 2024 12:45
@GuillaumeGomez GuillaumeGomez force-pushed the fix-single_element_loop-suggestion branch from 4762b99 to 8dd310d Compare July 18, 2024 12:50
@Alexendoo
Copy link
Member

Thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Jul 18, 2024

📌 Commit 8dd310d has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 18, 2024

⌛ Testing commit 8dd310d with merge bc2feea...

@bors
Copy link
Contributor

bors commented Jul 18, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing bc2feea to master...

@bors bors merged commit bc2feea into rust-lang:master Jul 18, 2024
8 checks passed
@GuillaumeGomez GuillaumeGomez deleted the fix-single_element_loop-suggestion branch July 18, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

single_element_loop: syntax error with never patterns ( missing parens)
4 participants