Fix tuple_array_conversions lint on nightly #11379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: changed
Const::eval_target_usize
toConsts::try_eval_target_usize
to get rid of ICE.I have encountered a problem with clippy: it caught ICE when working with a codebase that uses a lot of nightly features.
Here's a (stripped) ICE info:
I don't really know what's going on low-level-wise, but seems like this lin assumed that the length of the array can always be treated as
usize
, and I assume this doesn't play well withfeat(generic_const_exprs)
.I wasn't able to build a minimal reproducible example, but locally this fix does resolve the issue.