Fix find_format_arg_expr when incremental compilation is enabled
#10980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dswij (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Alexendoo
force-pushed
the
format-args-incremental-spans
branch
from
17f8fdd to
c4be901
Compare
Alexendoo
force-pushed
the
format-args-incremental-spans
branch
from
c4be901 to
26e78e7
Compare
dswij
approved these changes
Jun 19, 2023
Comment on lines
+426
to
+427
| // When incremental compilation is enabled spans gain a parent during AST to HIR lowering, | ||
| // since we're comparing an AST span to a HIR one we need to ignore the parent field |
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10969
lower_spangives AST spans a parent when lowering to the HIR. That meant the==span comparison would return false even though the spans are pointing to the same thing. We now ignore the parent when comparing the spansDebugging this was quite the puzzle, because the parent is not included in the debug output of
Spans orSpanData😬changelog: none