Skip to content

Small improvements to various files #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2019

Conversation

alexander-clarke
Copy link
Contributor

Various small fixes to:
11.1: This code will not run as there is no main function, so removed the ability to run it
24.1: This code will not run due to the crate_name being set to something other than playground. Could be changed in a different way, but running the code is not the purpose of this code example so I removed the ability to run it. This could be changed in a different way, open to discussion if this isn't the best.

3.2: Removed an unneeded attribute of allow(dead_code) as there isn't any dead code

8.5.1.4: Changed example to actually use match as all the other destructuring examples do. This is the biggest change so can be moved into its own pull request, but didn't want to split these issues so finely as they are all quite small.

Can split all of these into separate pull requests but wasn't sure if spamming the pull requests would be best.
Alex

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @marioidival (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@marioidival marioidival merged commit a18c3c4 into rust-lang:master Apr 22, 2019
@marioidival
Copy link
Member

@alexander-clarke thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants