Replace goblin crate with object #6817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Dec 11, 2020
crates/proc_macro_srv/Cargo.toml
Outdated
| libloading = "0.6.0" | ||
| memmap = "0.7" | ||
| object = { version = "0.22", git = "https://github.com/gimli-rs/object/" } |
There was a problem hiding this comment.
To pull in gimli-rs/object#261 for gimli-rs/object#222.
lnicola
force-pushed
the
shoo-goblin
branch
2 times, most recently
from
ee20c39 to
0e42e4b
Compare
lnicola
force-pushed
the
shoo-goblin
branch
3 times, most recently
from
7dc0245 to
170cdfe
Compare
|
bors try |
|
Hmm, we can merge it like this or wait until a new |
|
Why is the current (0.23) not good enough? |
|
It is, but with the fix in gimli-rs/object#261 we could probably disable the And maybe I should also replace the per-symbol string conversion with the |
|
I'd default to merging earlier and seding a followup, but you obv have more context here :) |
|
bors r=matklad |
That fix made it into the 0.23 release. |
bors bot
added a commit
that referenced
this pull request
Dec 23, 2020
7015: Disable the unaligned feature of the object crate r=lnicola a=lnicola We `mmap` the files so they should be reasonably aligned. Let's see what #6817 (comment) is about. Co-authored-by: Laurențiu Nicola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #4385.