Skip to content

fix: Turn "Remove dbg!" into a quick fix for better prioritization #18415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2024
Merged

fix: Turn "Remove dbg!" into a quick fix for better prioritization #18415

merged 1 commit into from
Oct 26, 2024

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Oct 26, 2024

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2024
@lnicola
Copy link
Member Author

lnicola commented Oct 26, 2024

The LSP examples for refactor.rewrite seem more heavy-weight than this one, I think it's fine to have it as a quick fix:

 * - Convert JavaScript function to class
 * - Add or remove parameter
 * - Encapsulate field
 * - Make method static
 * - Move method to base class

@lnicola lnicola enabled auto-merge October 26, 2024 06:13
@lnicola lnicola added this pull request to the merge queue Oct 26, 2024
Merged via the queue into rust-lang:master with commit 26d2fba Oct 26, 2024
9 checks passed
@lnicola lnicola deleted the nicer-remove-dbg branch October 26, 2024 06:35
@bors bors mentioned this pull request Oct 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dbg! should have higher priority than Inline macro
2 participants
@lnicola @rustbot