Assoc type bindings #1757
Merged
Assoc type bindings #1757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
reviewed
Sep 3, 2019
matklad
reviewed
Sep 3, 2019
|
LGTM with de-morgan transformation applied |
It's a bit complicated because we basically have to 'undo' the desugaring, and the result is very dependent on the specifics of the desugaring and will probably produce weird results otherwise.
If/when we switch to using Chalk's Ty, we'll need to replace this by its `Fold` trait, but I didn't want to import the whole thing just yet.
flodiebold
force-pushed
the
assoc-type-bindings
branch
from
ab08681 to
b8c1e40
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 3, 2019
1757: Assoc type bindings r=flodiebold a=flodiebold This adds support for type bindings (bounds like `where T: Iterator<Item = u32>`). It doesn't yet work in as many situations as I'd like because of some [Chalk problems](rust-lang/chalk#234). But it works in some situations, and will at least not bitrot this way ;) (part of the problem is that we use `Normalize` to normalize associated types, but produce `ProjectionEq` goals from where clauses, so Chalk can't normalize using the environment; this would be fixed by using `ProjectionEq` for normalization, which I think is the 'proper' way, but then we'd run into those ambiguity problems everywhere...) Co-authored-by: Florian Diebold <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for type bindings (bounds like
where T: Iterator<Item = u32>).It doesn't yet work in as many situations as I'd like because of some Chalk problems. But it works in some situations, and will at least not bitrot this way ;)
(part of the problem is that we use
Normalizeto normalize associated types, but produceProjectionEqgoals from where clauses, so Chalk can't normalize using the environment; this would be fixed by usingProjectionEqfor normalization, which I think is the 'proper' way, but then we'd run into those ambiguity problems everywhere...)