Skip to content

fix: Fix project linking popup appearing for modules that can be linked to a crate #14538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Apr 9, 2023

should fix #14523

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 9, 2023
@Veykril
Copy link
Member Author

Veykril commented Apr 9, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Apr 9, 2023

📌 Commit 9b60063 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 9, 2023

⌛ Testing commit 9b60063 with merge 81ba6af...

bors added a commit that referenced this pull request Apr 9, 2023
fix: Fix project linking popup appearing for modules that can be linked to a crate

should fix #14523
@bors
Copy link
Contributor

bors commented Apr 9, 2023

💔 Test failed - checks-actions

@Veykril Veykril force-pushed the project-link-fix branch from 9b60063 to 98a673c Compare April 9, 2023 08:18
@Veykril
Copy link
Member Author

Veykril commented Apr 9, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Apr 9, 2023

📌 Commit 98a673c has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 9, 2023

⌛ Testing commit 98a673c with merge 51d5862...

@bors
Copy link
Contributor

bors commented Apr 9, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 51d5862 to master...

@bors bors merged commit 51d5862 into rust-lang:master Apr 9, 2023
@griffi-gh
Copy link

griffi-gh commented Apr 10, 2023

finally fixed!
the popup was so annoying.

@Veykril Veykril deleted the project-link-fix branch April 10, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a new source file results in an unhelpful "This rust file does not belong to a loaded cargo project" notification
4 participants