Implement pattern mismatch diagnostics (but keep them disabled) #14222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
pat-mismatch-diags
branch
from
f156982 to
44e2c6e
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
This was referenced Mar 3, 2023
Merged
|
Turns out we record the mismatches without showing them in the metrics, will disable the diagnostic for this for the time being in a bit as this creates a lot of diagnostics. Our pattern inference seems to differ quite a bit from rustc's |
bors
added a commit
that referenced
this pull request
Mar 3, 2023
Disable pattern type mismatches again We have too many false mismatches at the moment for these to be enabled cc #14222
Veykril
changed the title
bors
added a commit
that referenced
this pull request
Mar 3, 2023
Disable pattern type mismatches again We have too many false mismatches at the moment for these to be enabled cc #14222
bors
added a commit
that referenced
this pull request
Mar 3, 2023
Disable pattern type mismatches again We have too many false mismatches at the moment for these to be enabled cc #14222
bors
added a commit
that referenced
this pull request
Mar 3, 2023
Disable pattern type mismatches again We have too many false mismatches at the moment for these to be enabled cc #14222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.