Skip to content

feat: Publish platform-specific Code VSIXes #11053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2021
Merged

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Dec 18, 2021

Closes #10483
CC #10371

Some notes:

  • we still build a plain VSIX, just in case
  • we build the extension on every platform to make the release workflow arguably cleaner
  • the Windows VSIX includes the PDB (but let's leave Backtraces on windows #10371 open until we change the Windows stand-alone release to a ZIP file)
  • npm doesn't run if started from xtask, possibly something related to path mapping; I moved the npm calls outside, but..
  • the Patch thingy doesn't work any more, so you'll end up with a dirty package.json of you run cargo xtask --client-patch-version; I don't think we should block on this
  • there's an untested Alpine build; for better or worse, we publish musl builds as alpine
  • I tested this as much as I could, but not the publishing and nightly updates
  • you can find some sample artifacts under https://github.com/lnicola/rust-analyzer/releases
  • we can now run the server from the install location (is Code planning to switch to compressed extensions?), except on NixOS
  • Code lets you install a VSIX for the wrong platform (with the results one would expect)
  • I don't know what happens if we try to publish a VSIX without a target

This is a relatively risky, but we'll probably have to take our chances with it.

r? @rust-analyzer/review

@@ -210,4 +230,4 @@ jobs:
if: github.ref == 'refs/heads/release'
working-directory: ./editors/code
# token from https://dev.azure.com/rust-analyzer/
run: npx vsce publish --pat ${{ secrets.MARKETPLACE_TOKEN }} --packagePath ../../dist/rust-analyzer.vsix
run: npx vsce publish --pat ${{ secrets.MARKETPLACE_TOKEN }} --packagePath ../../dist/rust-analyzer-*.vsix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this do the right thing? I am thinking about --packagePath foo bar vs --packagePath foo --packagePath bar.

Copy link
Member Author

@lnicola lnicola Dec 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope so, the help says:

  -i, --packagePath <paths...>    Publish the provided VSIX packages.

@matklad
Copy link
Member

matklad commented Dec 18, 2021

bors r=me

Seems broadly reasonable! Let's see if the nightly works!

@matklad
Copy link
Member

matklad commented Dec 18, 2021

(seeing most of ra team online at this late hour warms my heart :-)

@SomeoneToIgnore
Copy link
Contributor

This is a relatively risky

I wonder, would doing that after Monday's release be safer?

@lnicola
Copy link
Member Author

lnicola commented Dec 18, 2021

I wonder, would doing that after Monday's release be safer?

We still have to do it before a Monday, unless we make a special holidays release tomorrow (which I wouldn't mind). It's quite hard to test otherwise.

@matklad
Copy link
Member

matklad commented Dec 18, 2021

Not sure -- there's a stretch of holidays ahead, so it might makes sense to pack as much breakage as possible before that.

@bors
Copy link
Contributor

bors bot commented Dec 18, 2021

@bors bors bot merged commit b65d9c3 into rust-lang:master Dec 18, 2021
@matklad
Copy link
Member

matklad commented Dec 18, 2021

I like the idea of bonus christmas release :)

@lnicola
Copy link
Member Author

lnicola commented Dec 18, 2021

Or rather a "I'll probably have other non-holiday stuff on Monday, and I'd rather fix any fallout tomorrow instead" release.

@lnicola lnicola deleted the bundles branch December 18, 2021 21:26
@lnicola
Copy link
Member Author

lnicola commented Dec 18, 2021

By the way, thanks for the quick reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VS Code: Platform-specific Extensions
3 participants