-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: Publish platform-specific Code VSIXes #11053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -210,4 +230,4 @@ jobs: | |||
if: github.ref == 'refs/heads/release' | |||
working-directory: ./editors/code | |||
# token from https://dev.azure.com/rust-analyzer/ | |||
run: npx vsce publish --pat ${{ secrets.MARKETPLACE_TOKEN }} --packagePath ../../dist/rust-analyzer.vsix | |||
run: npx vsce publish --pat ${{ secrets.MARKETPLACE_TOKEN }} --packagePath ../../dist/rust-analyzer-*.vsix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this do the right thing? I am thinking about --packagePath foo bar
vs --packagePath foo --packagePath bar
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope so, the help says:
-i, --packagePath <paths...> Publish the provided VSIX packages.
bors r=me Seems broadly reasonable! Let's see if the nightly works! |
(seeing most of ra team online at this late hour warms my heart :-) |
I wonder, would doing that after Monday's release be safer? |
We still have to do it before a Monday, unless we make a special holidays release tomorrow (which I wouldn't mind). It's quite hard to test otherwise. |
Not sure -- there's a stretch of holidays ahead, so it might makes sense to pack as much breakage as possible before that. |
I like the idea of bonus christmas release :) |
Or rather a "I'll probably have other non-holiday stuff on Monday, and I'd rather fix any fallout tomorrow instead" release. |
By the way, thanks for the quick reviews! |
Closes #10483
CC #10371
Some notes:
npm
doesn't run if started fromxtask
, possibly something related to path mapping; I moved thenpm
calls outside, but..Patch
thingy doesn't work any more, so you'll end up with a dirtypackage.json
of you runcargo xtask --client-patch-version
; I don't think we should block on thismusl
builds asalpine
This is a relatively risky, but we'll probably have to take our chances with it.
r? @rust-analyzer/review