Skip to content

within asm! the token "in" highlights like a normal keyword, not like a register specifier. #10461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Lokathor opened this issue Oct 4, 2021 · 1 comment · Fixed by #18022
Closed

within asm! the token "in" highlights like a normal keyword, not like a register specifier. #10461

Lokathor opened this issue Oct 4, 2021 · 1 comment · Fixed by #18022
Labels
A-highlighting (semantic) token highlighting C-feature Category: feature request S-actionable Someone could pick this issue up and work on it right now

Comments

@Lokathor
Copy link

Lokathor commented Oct 4, 2021 •
edited
Loading

The "in" token should highlight the same as other register specifiers when used inside of asm!

Screenshot 2021-10-04 10 45 33

(note: it would also be fine if all register qualifiers and the options entry were highlighted like keywords, as long as it's consistent)
@jonas-schievink
Copy link
Contributor

We don't currently have any semantic highlighting for asm!, so this is just caused by the built-in grammar. cc #6031

@jonas-schievink jonas-schievink added the C-feature Category: feature request label Oct 5, 2021
@Veykril Veykril added A-highlighting (semantic) token highlighting S-actionable Someone could pick this issue up and work on it right now labels Dec 4, 2021
@Veykril Veykril mentioned this issue Sep 5, 2024
Merged
@bors bors closed this as completed in d927daf Sep 5, 2024
lnicola pushed a commit to lnicola/rust that referenced this issue Sep 25, 2024
@bors
Auto merge of rust-lang#18022 - Veykril:asm-parse, r=Veykril
bdfb2f6 
feat: IDE support for `asm!` expressions

Fixes rust-lang/rust-analyzer#10461, Fixes rust-lang/rust-analyzer#6031 Progresses rust-lang/rust-analyzer#11621

Notably this only works for asm expressions not items yet. Most IDE features work, mainly completions need extra logic still.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-highlighting (semantic) token highlighting C-feature Category: feature request S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: IDE support for asm! expressions Veykril/rust-analyzer
3 participants
@jonas-schievink @Veykril @Lokathor