Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Allow reformat to be a no-op #334

Closed
nrc opened this issue May 29, 2017 · 0 comments
Closed

Allow reformat to be a no-op #334

nrc opened this issue May 29, 2017 · 0 comments
Labels
P-high

Comments

@nrc
Copy link
Member

nrc commented May 29, 2017

That is, if there are no changes, don't send a change back from the RLS. Rustfmt knows this, but doesn't expose it in the API we use, so this primarily needs fixing in Rustfmt.
@nrc nrc mentioned this issue May 29, 2017
Closed
9 tasks
@nrc nrc added the P-high label Aug 6, 2017
@Xanewok Xanewok mentioned this issue Mar 2, 2019
Merged
bors added a commit that referenced this issue Apr 6, 2019
@bors
Auto merge of #1385 - Xanewok:rustfmt-modified-lines, r=Xanewok
49efc06 
Return only modified lines in formatting responses

Ticks few boxes in #3. (that's an early issue!)
Closes #334.

This is currently based on rust-lang/rustfmt#3424 and so currently blocked until it merges.

Configures Rustfmt to use `EmitMode::ModifiedLines` and parses the response - this should work with both statically-linked and externally provided Rustfmt.

@alexheretic do you think you could take a look and double-check?
@bors bors closed this as completed in #1385 Apr 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P-high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nrc