Skip to content

Key binding to defocus the search bar in Rustdoc pages #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ghost opened this issue Dec 25, 2017 · 2 comments
Closed

Key binding to defocus the search bar in Rustdoc pages #2265

ghost opened this issue Dec 25, 2017 · 2 comments
Labels
T-doc Relevant to the documentation team, which will review and decide on the RFC.

Comments

@ghost
Copy link

ghost commented Dec 25, 2017

The key bindings in Rustdoc pages are very useful and allow quick navigation. However, after pressing the S key, it's not possible to defocus the search bar, making it impossible to scroll down using the arrow keys.
I propose an addition to the key bindings so that the escape key makes the search bar lose focus.
@Centril Centril added the T-doc Relevant to the documentation team, which will review and decide on the RFC. label Dec 25, 2017
@untitaker
Copy link
Contributor

I don't think this requires an RFC, but I am not sure.

@ghost ghost mentioned this issue Jan 2, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Jan 3, 2018
@kennytm
Rollup merge of rust-lang#47134 - Sogomn:master, r=QuietMisdreavus
08501bd 
Defocus search bar in rustdoc pages

rust-lang/rfcs#2265
@ghost
Copy link
Author

ghost commented Jan 4, 2018

rust-lang/rust#47134

@ghost ghost closed this as completed Jan 4, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-doc Relevant to the documentation team, which will review and decide on the RFC.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@untitaker @Centril