Skip to content

Expand ABI support by replacing opaque items #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
celinval opened this issue Dec 19, 2023 · 0 comments · Fixed by rust-lang/rust#121824
Closed

Expand ABI support by replacing opaque items #58

celinval opened this issue Dec 19, 2023 · 0 comments · Fixed by rust-lang/rust#121824
Assignees
@celinval

Comments

@celinval
Copy link
Contributor

celinval commented Dec 19, 2023 •
edited
Loading

We are adding some basic support to function ABI and type layout in this PR: rust-lang/rust#119094, however, some information was left as Opaque for now.

We still need to expand the following:

### Tasks
- [ ] Add information about `Scalar`.
- [ ] Expand PassMode attributes.
- [ ] Add information about `Primitive`
@celinval celinval mentioned this issue Dec 19, 2023
Merged
@celinval celinval self-assigned this Feb 22, 2024
@celinval celinval mentioned this issue Feb 22, 2024
Open
4 tasks
@celinval celinval mentioned this issue Mar 1, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Mar 1, 2024
@matthiaskrgr
Rollup merge of rust-lang#121824 - celinval:smir-scalar, r=oli-obk
57ac137 
Implement missing ABI structures in StableMIR

Add implementations for Scalar, Primitive and WrappingRange for StableMIR.

FYI, I thought about reusing the `rustc_abi` module, since it is designed to not necessarily depend on the `rustc` internals, but the maintenance burden to maintain this crate in crates.io doesn't seem worth it at this point.

Fixes rust-lang/project-stable-mir#58
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 2, 2024
@rust-timer
Unrolled build for rust-lang#121824
56c520b 
Rollup merge of rust-lang#121824 - celinval:smir-scalar, r=oli-obk

Implement missing ABI structures in StableMIR

Add implementations for Scalar, Primitive and WrappingRange for StableMIR.

FYI, I thought about reusing the `rustc_abi` module, since it is designed to not necessarily depend on the `rustc` internals, but the maintenance burden to maintain this crate in crates.io doesn't seem worth it at this point.

Fixes rust-lang/project-stable-mir#58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@celinval celinval

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement missing ABI structures in StableMIR celinval/rust-dev
1 participant
@celinval