-
Notifications
You must be signed in to change notification settings - Fork 385
Rustup #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
that function has been removed
…uninitialized static error
Rustup to rustc 1.27.0-nightly (79252ff4e 2018-04-29)
Appveyor:
|
that's easy to fix... travis is failing with
and I can reproduce locally :( |
miri/fn_call.rs
Outdated
@@ -4,6 +4,7 @@ use rustc::hir::def_id::{DefId, CRATE_DEF_INDEX}; | |||
use rustc::mir; | |||
use rustc_target::spec::abi::Abi; | |||
use rustc_data_structures::indexed_vec::Idx; | |||
use rustc_target::spec::abi::Abi; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate of two lines above
(...)
That is because Reproduction using modified priroda, to use the same logic as miri for the first frame: https://screenshots.firefox.com/HDUYaPBZm1sfgpdk/localhost |
With
|
O.m.g. so obvious in hindsight! |
miri/validation.rs
Outdated
Variants::Tagged { ref tag, .. } => { | ||
assert_eq!(i, 0); | ||
return Ok(tag.value.to_ty(tcx)) | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be duplicated, just write tag: ref discr
like the NicheFilling
case does with niche
.
Fixed build for latest nightly (again)
Alloc api fix and tmp disable validation_op because of ICE
Error when
|
Yeah I suggest to just disable validation for now. |
Four
Edit: submitted rust-lang/rust#50567 |
WE ARE BACK IN BUSINESS Rule 39 applies, because this is cool! |
Hooray!!! Will update priroda soon! Edit: updated |
Wow, awesome. Thanks a ton :) |
cc @bjorn3