Implement some `llvm.x86.sse2.*` intrinsics and add tests #3055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bors merged 3 commits into rust-lang:master from eduardosm:x86-sse2-intrinsics

Sep 12, 2023

Contributor

eduardosm commented Sep 8, 2023

Continuation of #2989 with SSE2 intrinsics.

Thankfully, a significant amount of SSE2 functions use simd_* intrinsics, which are already implemented in Miri.

RalfJung reviewed

View reviewed changes

tests/pass/intrinsics-x86-sse2.rs Outdated Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

src/shims/x86/sse2.rs Outdated Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

src/shims/x86/sse2.rs Outdated Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

src/shims/x86/sse2.rs Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

src/shims/x86/sse2.rs Outdated Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

src/shims/x86/sse2.rs Outdated Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

src/shims/x86/sse2.rs Outdated Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

src/shims/x86/sse2.rs Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

src/shims/x86/sse2.rs Outdated Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

src/shims/x86/sse2.rs Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

src/shims/x86/sse2.rs Outdated Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

src/shims/x86/sse2.rs Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

src/shims/x86/sse2.rs Outdated Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

src/shims/x86/sse2.rs Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

tests/pass/intrinsics-x86-sse2.rs Outdated Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

src/shims/x86/sse2.rs Outdated Show resolved Hide resolved

Member

RalfJung commented Sep 11, 2023

@rustbot author

rustbot added the S-waiting-on-author label

Contributor Author

eduardosm commented Sep 11, 2023

rustbot added S-waiting-on-review and removed S-waiting-on-author labels

RalfJung reviewed

View reviewed changes

src/shims/x86/sse2.rs Outdated Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

src/shims/x86/sse2.rs Outdated Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

src/shims/x86/sse2.rs Outdated Show resolved Hide resolved

RalfJung reviewed

View reviewed changes

tests/pass/intrinsics-x86-sse.rs Show resolved Hide resolved

Member

RalfJung commented Sep 12, 2023

All right, looking great overall! Please squash into <4 commits, then we can land this. :)

eduardosm added 3 commits

September 12, 2023 19:29


          Fix a few typos in shims/x86/sse.rs comments

d372bac


          Ignore all archs except x86 and x86_64 in SSE tests

1dcf31d


          Implement some llvm.x86.sse2.* intrinsics and add tests

Implements LLVM intrisics needed to run most SSE2 functions from `core::arch::x86{,_64}`.

Also adds miri tests for those functions (mostly copied from core_arch tests).

Contributor Author

eduardosm commented Sep 12, 2023

Ready!

Contributor Author

eduardosm commented Sep 12, 2023

Remainder to myself:

Implement bin_op_f32/bin_op_f64 with generics to reduce code duplication.
Figure out a widening conversion helper function to implement avg and mulh without host integer arithmetic.

I will work on that once this lands in the main Rust repo because I expect to add helpers to rustc_middle.

Member

RalfJung commented Sep 12, 2023

Thanks. :)
@bors r+

I will work on that once this lands in the main Rust repo because I expect to add helpers to rustc_middle.

I expect it will be rustc_const_eval, but it will be on the rustc side either way.

Contributor

bors commented Sep 12, 2023

📌 Commit 0567761 has been approved by RalfJung

It is now in the queue for this repository.

Contributor

bors commented Sep 12, 2023

⌛ Testing commit 0567761 with merge 0143f1f...

Contributor

bors commented Sep 12, 2023

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 0143f1f to master...

bors merged commit 0143f1f into rust-lang:master

Member

RalfJung commented Sep 13, 2023

@eduardosm his is synced into rustc now.

saethlin removed the S-waiting-on-review label

eduardosm deleted the x86-sse2-intrinsics branch

September 24, 2023 12:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet