Skip to content

Disable diagnostic duplication #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RalfJung opened this issue Mar 3, 2024 · 0 comments · Fixed by #3351
Closed

Disable diagnostic duplication #3350

RalfJung opened this issue Mar 3, 2024 · 0 comments · Fixed by #3351

Comments

@RalfJung
Copy link
Member

RalfJung commented Mar 3, 2024

We'll want to disable diagnostic duplication in Miri, at least when "tracking" of some sort is enabled. I just wasted literal hours debugging why a certain load event did not happen that was supposed to happen, when actually the output just got deduplicated away...

bors added a commit that referenced this issue Mar 4, 2024
…=RalfJung

disable diagnostic deduplication

`@oli-obk` is there a better way to do this? Ideally we'd only set this when interpretation starts but the value in the compiler session seems to be immutable. I assume people will do `cargo check` before `cargo miri` so hopefully this won't lead to too much confusion.

Fixes #3350
@bors bors closed this as completed in 8000dab Mar 4, 2024
RalfJung pushed a commit to RalfJung/rust that referenced this issue Mar 9, 2024
…armful, r=RalfJung

disable diagnostic deduplication

`@oli-obk` is there a better way to do this? Ideally we'd only set this when interpretation starts but the value in the compiler session seems to be immutable. I assume people will do `cargo check` before `cargo miri` so hopefully this won't lead to too much confusion.

Fixes rust-lang/miri#3350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant