Change deprecated constants into hidden constants #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustc, an important libc consumer, has a policy that they can't use any crates with deprecated symbols. Replace libc's two deprecated symbols with hidden symbols instead.
|
@bors: r+ |
|
📌 Commit 6e8e7cf has been approved by |
bors
added a commit
that referenced
this pull request
Dec 17, 2017
Change deprecated constants into hidden constants rustc, an important libc consumer, has a policy that they can't use any crates with deprecated symbols. Replace libc's two deprecated symbols with hidden symbols instead.
|
☀️ Test successful - status-appveyor, status-travis |
semarie
referenced
this pull request
in ruuda/thread-id
Dec 18, 2017
The libc crate started using the #[deprecated] attribute, which is not supported on Rust 1.8.0 stable, and results in a compile error. This change was presumably introduced in commit 13ce9f8 [1] as part of pull request 859 [2]. The solution is to put Cargo.lock under source control and freeze all dependency versions, to be more resilient to external changes. [1]: rust-lang/libc@13ce9f8 [2]: rust-lang/libc#859
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustc, an important libc consumer, has a policy that they can't use any
crates with deprecated symbols. Replace libc's two deprecated symbols
with hidden symbols instead.