Skip to content

Add AF_UNSPEC from Apple socket.h #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2017
Merged

Add AF_UNSPEC from Apple socket.h #514

merged 1 commit into from
Feb 8, 2017

Conversation

DoumanAsh
Copy link
Contributor

socket.h of Apple contains this definition so i'm not sure why it is missing from libc.
The same goes for other BSD-like OSes...
Is there some particular reasons why it is so?

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 7, 2017

📌 Commit 45ba8c1 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Feb 7, 2017

⌛ Testing commit 45ba8c1 with merge 6813109...

bors added a commit that referenced this pull request Feb 7, 2017
Add AF_UNSPEC from Apple socket.h

[socket.h](https://opensource.apple.com/source/xnu/xnu-792.13.8/bsd/sys/socket.h) of Apple contains this definition so i'm not sure why it is missing from libc.
The same goes for other BSD-like OSes...
Is there some particular reasons why it is so?
@bors
Copy link
Contributor

bors commented Feb 8, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 6813109 to master...

@bors bors merged commit 45ba8c1 into rust-lang:master Feb 8, 2017
Susurrus pushed a commit to Susurrus/libc that referenced this pull request Mar 26, 2017
Susurrus pushed a commit to Susurrus/libc that referenced this pull request Mar 26, 2017
Added BaudRate enum for termios

Issue rust-lang#514

Does not provide `BaudRate::EXTA` or `BaudRate::EXTB` constants. These seem to alias to `B19200` and `B38400` respectively and so break the 1:1 mapping needed by `From`.  I don't know their historic use.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants