-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Relocate <spawn.h> functions to define them to dragonfly. #4294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
While here: - Relocate mkostemp and mkostemps functions for same reason - Update semver tests for DF spawn and mkostemp(s)
replaces #4294 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after CI passes, please add permalinks to the actual headers in the PR description.
@rustbot label +stable-nominated
Okay, I updated the PR description with links to github mirror to the headers. |
Oh does Dragonfly just use the FreeBSD headers? Thanks for the links, I updated them to permalinks so we have a reference if things change. That job has been a bit flaky through Cirrus updates, looks like it passed with a rerun. |
oh, sorry, that was a mistake, I'm not sure what I was thinking about those headers.. I will update again. |
Okay, both FreeBSD and DragonFly header paths are provided now. |
Awesome, thank you. I updated these to permalinks as well (it's just an option under the triple dots when looking at a file on GH). |
While here: - Relocate mkostemp and mkostemps functions for same reason - Update semver tests for DF spawn and mkostemp(s) (backport <rust-lang#4294>) [ update constants to c_int to match libc-0.2 - Trevor ] (cherry picked from commit a294be6)
While here: - Relocate mkostemp and mkostemps functions for same reason - Update semver tests for DF spawn and mkostemp(s) (backport <rust-lang#4294>) [ update constants to c_int to match libc-0.2 - Trevor ] (cherry picked from commit a294be6)
While here:
Description
This changeset exposes bindings for mkostemp, mkostemps, and the <spawn.h> functions on DragonFly.
It does this by moving freebsd-specific definitions in the generic freebsdlike mod.rs file.
These are required to build fish 4.0.0 (https://github.com/fish-shell/fish-shell)
Sources
FreeBSD
https://github.com/freebsd/freebsd-src/blob/e7c0cb720898fd36487c4e6b0aff52435084e6bf/include/spawn.h
https://github.com/freebsd/freebsd-src/blob/e7c0cb720898fd36487c4e6b0aff52435084e6bf/include/stdlib.h#L305-L307
DragonFly
https://raw.githubusercontent.com/DragonFlyBSD/DragonFlyBSD/refs/heads/master/include/spawn.h
https://raw.githubusercontent.com/DragonFlyBSD/DragonFlyBSD/refs/heads/master/include/stdlib.h
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI