Add siginfo accessors for uclibc #2750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
|
Builds and tests pass with |
|
@bors r+ |
|
📌 Commit da00f55 has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
Closed
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 6, 2022
bump libc version for uclibc fixes closes rust-lang#95866 The required functions have been added to libc in rust-lang/libc#2750. That change made it into libc 0.2.124, but this just takes the latest libc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With rust-lang/rust#95688 switching to the libc-provided
si_addr()accessor onsiginfo_t, it became apparent that the uclibc target was lacking that implementation (see rust-lang/rust#95866).It would be nice to provide the same accessor in uclibc as the other UNIX-y platforms.
CC: @asomers @name1e5s @skrap - If you have a testing env for this, could you try it out?