Skip to content

Don't create a duplicate title on rustdoc pages #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Aug 15, 2020

Since the LOL HTML rewrite, we show both the rustdoc title and the
docs.rs title. We should only show the rustdoc title.

Closes #971
r? @Kixiron

Since the LOL HTML rewrite, we show both the rustdoc title and the
docs.rs title. We should only show the rustdoc title.
@jyn514 jyn514 added C-bug Category: This is a bug A-frontend Area: Web frontend S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Aug 15, 2020
@jyn514
Copy link
Member Author

jyn514 commented Aug 15, 2020

Before: before-title

After:
title

@jyn514 jyn514 merged commit 330edaa into rust-lang:master Aug 15, 2020
@jyn514 jyn514 deleted the titular branch August 15, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend Area: Web frontend C-bug Category: This is a bug S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid creating two <title>s
2 participants