Refactored the Badges crate #675
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
suggested changes
Apr 1, 2020
There was a problem hiding this comment.
Thank you so much for the contribution! Everything in this refactor is good, but it tries to do too much at once. Please split this up into 2 PRs:
- Formatting and style changes (it looked like you ran
clippyandrustfmton badge alone which is fine) - Updating the dependencies. We've been burned by this before, it should be separate so it's easy to revert if necessary.
|
|
||
| [dependencies] | ||
| base64 = "0.9.0" | ||
| rusttype = "0.7" |
There was a problem hiding this comment.
Please do not update dependencies in a refactor PR. You can make a separate PR for this.
jyn514
reviewed
Apr 1, 2020
| let mut file = File::create("test.svg").unwrap(); | ||
| let options = BadgeOptions { | ||
| subject: "build".to_owned(), | ||
| status: "passing".to_owned(), | ||
| ..BadgeOptions::default() | ||
| }; | ||
| let badge = Badge::new(options).unwrap(); | ||
|
|
||
| file.write_all(badge.to_svg().as_bytes()).unwrap(); |
There was a problem hiding this comment.
I think a better idea might be to write the badge to memory instead of to disk. It would also be nice to compare it to a known good badge, but it would be fine even without.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test.svg)