navigation_rustdoc: show whether a build failed in the Versions list #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces the same change as 3cf195e to navigation_rustoc.
|
We could avoid the code duplication by extracting this part into a separate .hbs file. But I'm not sure if that is worth doing for about 10 lines of code. |
|
I think for this little code it's fine to have some duplication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR are very similar to #546. In fact, the code introduced here is exactly the same as in
crate_details.hbsThis PR impacts the navigation bar in the rustdoc view: in the dropdown menu, versions that failed to build will also have a⚠️ sign now.
Screenshot taken with changes from this PR: